Skip to content

Apply Sourcery suggestions and fix typos #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

@DimitriPapadopoulos DimitriPapadopoulos changed the title Apply Sourcery suggestiosn and fix typos Apply Sourcery suggestions and fix typos Jun 13, 2025
@DimitriPapadopoulos DimitriPapadopoulos force-pushed the sourcery branch 2 times, most recently from 106f22d to 1d1547b Compare June 13, 2025 22:28
@martindurant
Copy link
Member

I'm not convinced that every change is an improvement, but it all seems to be OK. Are you planning to do more work here?

@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Jun 16, 2025

Do you have in mind the changes from str + str to f"{str}{str}"? Not sure about them either. While f-strings are faster and considered more readable in a majority of situations, they might not be an improvement here. I can revert this class of changes if you agree, absolutely not a problem.

I don't intend adding more changes (although Sourcery suggests more). I do think it might be worthwhile to add Sourcery to the repository, it provides AI assistance for PR review. I find it useful, although not bulletproof or astounding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants